Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump: tag and release v1.0.0 #748

Merged
merged 1 commit into from
Aug 15, 2023
Merged

bump: tag and release v1.0.0 #748

merged 1 commit into from
Aug 15, 2023

Conversation

shizhMSFT
Copy link
Contributor

@shizhMSFT shizhMSFT commented Jul 21, 2023 •
edited
Loading

Release

This would mean tagging 80e3fc4 as v1.0.0 to release.

Vote

We need at least 4 approvals from 6 maintainers to release notation v1.0.0.

Changes

The code changes compared to v1.0.0-rc.7 include:

Full Changelog: v1.0.0-rc.7...80e3fc4

Action Requested

Please respond LGTM (approve) or REJECT (request for changes).

@shizhMSFT shizhMSFT added this to the 1.0.0 milestone Jul 21, 2023
@shizhMSFT shizhMSFT mentioned this pull request Jul 21, 2023
Closed
15 tasks
@JeyJeyGao
Copy link
Contributor

LGTM

@shizhMSFT shizhMSFT marked this pull request as ready for review August 8, 2023 00:33
@priteshbandi
Copy link
Contributor

Should we do a dev build before 1.0 to do a round of sanity test?

@shizhMSFT
Copy link
Contributor Author

shizhMSFT commented Aug 8, 2023 •
edited
Loading

Should we do a dev build before 1.0 to do a round of sanity test?

We have the build on the main branch passing (as well as this PR). Meanwhile, we have released v1.0.0-rc.7 that the release pipeline has no issue. Thus, I think we are fine to not have a dev build.

If you have concerns, we can enable the weekly dev release workflow and manually trigger the workflow to publish a dev release.

Two-Hearts
Two-Hearts approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 2e49d1b into notaryproject:main Aug 15, 2023
@shizhMSFT shizhMSFT deleted the prep-v1.0.0 branch August 15, 2023 00:47
@Two-Hearts Two-Hearts mentioned this pull request Jan 25, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Two-Hearts Two-Hearts Two-Hearts approved these changes

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@justincormack justincormack Awaiting requested review from justincormack

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

Assignees
No one assigned
Labels
None yet
Projects
Notary Project Planning Board
Status: Done
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shizhMSFT @JeyJeyGao @priteshbandi @Two-Hearts